Basic code modernization #480
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This module requires perl 5.8.1, it can use our. This also better prepares for using strict properly.
This module requires perl 5.8.1, XSLoader is always available.
Assigning a scalar to splice has been a compile error since at least perl 5.8, so these subs are definitely never used and could be deleted. But it's also simple to fix them.
AutoLoader has not been a reasonable optimization for a long time.
There is no reason to prefer use vars over our since we require perl 5.8.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the use of AutoLoader. It's an optimization that hasn't been relevant for decades. This required fixing a number of syntax and compile errors in the autoloaded subs. The autoloaded subs with compile errors haven't worked since at least perl 5.8, so they could be removed. But for now they were left in place.
Removes the use of
use vars, which hasn't been needed since perl 5.6.Removes the fallback to DynaLoader, which hasn't been needed since perl 5.8.