Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

untested and unreviewed heap allocator #291

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

untested and unreviewed heap allocator #291

wants to merge 3 commits into from

Conversation

trufae
Copy link
Collaborator

@trufae trufae commented Feb 28, 2025

Checklist

  • Closing issues: #issue
  • Mark this if you consider it ready to merge
  • I've added tests (optional)
  • I wrote some documentation

Description

github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 28, 2025
View reviewed changes
src/heap.c
// Get size of the free list item.
static inline int getSize(void *ptr) {
return ((Header *)remove_offset (ptr))->size;
static inline int getBlockSize(void *payload_ptr) {

Check notice

Code scanning / CodeQL

Unused static function Note

Static function getBlockSize is unreachable
src/heap.c
// Coalesce with adjacent free blocks if possible
// Coalesce backward
Header *current_header = header;
//bool merged_prev = false;

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trufae @radare