Search for user DN in the scope of LDAP user base before authentication #464
+45
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rezib
force-pushed
the
pr/feat-446-447
branch
2 times, most recently
from
d93a4a1 to
7088ffd
Compare
Introduce ldap > lookup_user_dn boolean parameter for the gateway.
Lookup user DN in the scope of user base subtree before authentication on LDAP directory by default. This has 2 main benefits: - Support LDAP directory layout with users distributed in multiple branches in the user base. - Support LDAP directory without the user name attribute in the user DN (eg. the full name). Note this new default behavior can be reverted to the previous behavior by setting lookup_user_dn=no in [ldap] section of the gateway configuration. fix #446 #447
rezib
force-pushed
the
pr/feat-446-447
branch
from
7088ffd to
5ab02a3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #446 #447