Asynchronous requests to retrieve stats in clusters list #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rezib
added
the
refactor
rezib
force-pushed
the
pr/fix-428
branch
3 times, most recently
from
1cd70d7 to
8f01abe
Compare
rezib
force-pushed
the
pr/fix-428
branch
2 times, most recently
from
6da46b0 to
fccbb10
Compare
Do not return clusters global stats in /clusters endpoint anymore. These stats can take lot of time to get from clusters, depending on the number of jobs and cache status. The user experience is better if the frontend can quickly retrieve the clusters list with their permissions and then clusters stats asynchronously.
Instead of expecting the clusters stats in response along the clusters list, send asynchronous requests to retrieve the stats on all clusters after the list of clusters is rendered to users. fix #428
Introduce ClusterListItem component in order to move some code out of ClustersView and simplify logic of parallel and asynchronous cluster stats retrieval.
Do not report ongoing issue when users do not have permission on view-stats action on a cluster in clusters list page.
Display loading spinner when loading cluster stats in clusters list.
Add unit tests to cover ClustersView and ClustersListItem component.
Introduce ClusterDescription boolean error flag to share error status when retrieving stats between ClustersListItem and ClustersPopOver components.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tasks are still pending:
/clustersresponsefix #428