Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always convert to the shortest map<> variant #1

Open
mr-c opened this issue Apr 8, 2020 · 3 comments
Open

always convert to the shortest map<> variant #1

mr-c opened this issue Apr 8, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@mr-c
Copy link
Contributor

mr-c commented Apr 8, 2020

Would you accept a PR to add this?

@ghost
Copy link

ghost commented Apr 29, 2020

Oddly, I was thinking about this too. As always, PRs most welcome, but I had a thought. I personally prefer this, as you know, because the map form avoids duplicate ids by accident and is more compact.

However, I wonder if the user is trying to maintain a certain sorted order of, say steps, by writing them out as a list.

My inclination is to say, please go ahead @mr-c and let's do this, and only if people complain should we change the policy.

@ghost ghost assigned mr-c Apr 29, 2020
@ghost ghost added the enhancement New feature or request label Apr 29, 2020
@mr-c
Copy link
Contributor Author

mr-c commented Apr 29, 2020

Ordered maps are easy with ruamel.yaml 😁👍

@ghost
Copy link

ghost commented Apr 29, 2020

The current default behavior of cwl-format is to order such dicts alphabetically. Should this be changed then to not reorder?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant