Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite loop when no input file is given as argument instead of reading standard input #24

Closed
CratesDeThebes opened this issue Sep 18, 2024 · 2 comments · Fixed by #29
Assignees
Labels
bug Something isn't working
Milestone

Comments

@CratesDeThebes
Copy link

Documentation states that the executable defaults to read stdin and with option -i it uses file as input netlist.
Currently, when running the executable without option, an infinite loop starts and can only be interrupted with CTRL-C keys.

This behaviour is due to the code in ucs.cpp, when no argument is found, a first step opens the input file and searches for --path and --module and then closes the input file. This step should wrapped in a if (infile != NULL) {...} block.

@ra3xdh ra3xdh added the bug Something isn't working label Sep 18, 2024
@ra3xdh
Copy link
Owner

ra3xdh commented Sep 18, 2024

Yes, I confirm this bug. To be honestly, I never used the reading of the STDIN with qucsator and didn't test this. I am not sure when it became broken. If you are using qucsator inside some script, you may specify the input file with -i option. I will provide a fix in the next release.

@ra3xdh ra3xdh added this to the 1.0.3 milestone Sep 18, 2024
@ra3xdh ra3xdh linked a pull request Sep 30, 2024 that will close this issue
@ra3xdh ra3xdh self-assigned this Sep 30, 2024
@ra3xdh
Copy link
Owner

ra3xdh commented Sep 30, 2024

Fixed by #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants