-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing text in schematic after upgrading to Qt-6.8.0 #995
Conversation
It's need to check if default zero-width curves on diagrams and other objects are drawn correctly with Qt6.8.0 |
So far the default zero-width curves draw fine. Shape paintings work too. Text painting doesn't draw any text if not patched. For every element lines and shapes draw fine, text doesn't if the bounding rectangle is actually a point. |
this is a qt bug https://bugreports.qt.io/browse/QTBUG-129914 and this issue fixed by this commit. https://codereview.qt-project.org/c/qt/qtbase/+/597019 We shouldn't switch Qt 6.8.0 and we should wait Qt 6.8.1 and now Qt 6.7.2 is stable enough. Qt 6.7.3 also problematic. |
Qt version in Arch now is 6.8.0 and in Tumbleweed 6.7.3. It might be better to fix Qucs-s and avoid that corner case. |
@ra3xdh If all drawText calls are patched we are good to go. |
You forgot |
diagram.cpp:134 is not the same function call, it is not affected. The bug report that @dsm found explains it. |
Then I am removing the WIP label and merging. |
After upgrading to Qt-6.8 calling QPainter::drawText with zero width, zero height and Qt::TextDontClip flag doesn't draw any text.


Setting width and height to 1 fixes it.