Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing text in schematic after upgrading to Qt-6.8.0 #995

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

ivandi69
Copy link
Contributor

After upgrading to Qt-6.8 calling QPainter::drawText with zero width, zero height and Qt::TextDontClip flag doesn't draw any text.
image
Setting width and height to 1 fixes it.
image

@ra3xdh ra3xdh added this to the 24.4.0 milestone Oct 16, 2024
@ra3xdh ra3xdh added the qt6 label Oct 16, 2024
@ra3xdh
Copy link
Owner

ra3xdh commented Oct 16, 2024

It's need to check if default zero-width curves on diagrams and other objects are drawn correctly with Qt6.8.0

@ivandi69
Copy link
Contributor Author

So far the default zero-width curves draw fine. Shape paintings work too. Text painting doesn't draw any text if not patched. For every element lines and shapes draw fine, text doesn't if the bounding rectangle is actually a point.

@dsm
Copy link
Collaborator

dsm commented Oct 16, 2024

this is a qt bug https://bugreports.qt.io/browse/QTBUG-129914

and this issue fixed by this commit. https://codereview.qt-project.org/c/qt/qtbase/+/597019

We shouldn't switch Qt 6.8.0 and we should wait Qt 6.8.1 and now Qt 6.7.2 is stable enough. Qt 6.7.3 also problematic.

@dsm dsm marked this pull request as ready for review October 16, 2024 17:42
@dsm dsm marked this pull request as draft October 16, 2024 17:42
@ivandi69
Copy link
Contributor Author

Qt version in Arch now is 6.8.0 and in Tumbleweed 6.7.3. It might be better to fix Qucs-s and avoid that corner case.

@ra3xdh
Copy link
Owner

ra3xdh commented Oct 19, 2024

This solution should be merged, because the Arch users are already sending bugreports. The Arch users are a big percent of Linux users. And there is no way to downgrade Qt on Arch. See #1002

This PR is marked as WIP. @ivandi69 , are you planning to add more commits to this?

@ra3xdh ra3xdh linked an issue Oct 19, 2024 that may be closed by this pull request
@ivandi69
Copy link
Contributor Author

@ra3xdh If all drawText calls are patched we are good to go.

@ra3xdh
Copy link
Owner

ra3xdh commented Oct 19, 2024

You forgot diagram.cpp line 134 Other occurrence of drawText are fixed.

@ivandi69
Copy link
Contributor Author

diagram.cpp:134 is not the same function call, it is not affected. The bug report that @dsm found explains it.

@ra3xdh
Copy link
Owner

ra3xdh commented Oct 20, 2024

Then I am removing the WIP label and merging.

@ra3xdh ra3xdh marked this pull request as ready for review October 20, 2024 10:11
@ra3xdh ra3xdh merged commit fdd487d into ra3xdh:current Oct 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing text in all labels or symbols (Qt 6.8.0)
3 participants