-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor node #845
Refactor node #845
Conversation
- Remove dependency on Q3PtrList (most important) - Hide implementation details (in particular make private container used to actually store connected elements) - New class API - Formatting and code structuring
@ra3xdh, @wawuwo, Hi, some changes related but my work not done properly, I just got back from holiday, I choose this way for Connections in node.h in sweepdialog.cpp I removed this lines not confusing for loop variables:
|
I have tested this and didn't found issues with schematic editing, save, load. I am merging this. |
@wawuwo I have found a crash related to this PR. It is not possible to place the device on wire. Normal device connection works as expected. The placing of one device port on wire works as expected. Steps to reproduce:
Could you have a look? |
@ra3xdh,I am almost certain that the reason is that connected elements are being removed from node's internal I don't have a solution right now, need some time to think what could be done |
Hi!
I've refactored the Node class to address the problem from #748.
@dsm seems to be working on the same issue in #832, but in a broader scope, I hope this piece doesn't interfere with his work. Anyway some synchronisation may be required upon merging (if it happens).
List of changes:
I've done some tests on my side, in particular:
All described above went smoothly, but one cannot be 100% sure; some nasty bug is probably hiding waiting for perfect conditions to occur :(