Make tuner inputs accept fractional numbers only in "C" format #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Input fields on tuner form use QDoubleValidators which by default operate in user's native locale. But unfortunately some other parts of tuner codebase are not locale-aware, which leads to bugs if user's native locale number formatting differs from that in "C". This commit makes tuner inputs native locale unaware, i.e. accept fractional numbers only if - dot is integral/fractional part separator - there is no group separators in number Scientific notation is accepted. Fixes ra3xdh#416
|
Thanks for providing fix! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This is a quick fix of #416 based on a solution offered in this comment
Recap of the problem:
Input fields on tuner form use QDoubleValidators which by default operate in user's native locale. But unfortunately some other parts of tuner codebase are not locale-aware, which leads to bugs if user's native locale number formatting differs from that in "C".
This PR makes tuner inputs unaware about native locale and use "C" instead, i.e. accept fractional numbers only if
Scientific notation is still accepted.