Refactor Schematic::sizeOfSelection #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schematic::sizeOfSelection have a set of variables declared in the beginning of function body. These variables are used as loop variables further down in function body, which is bad because: - variable declarations are far from their actual usage - variables have unnecessary large scope This commit replaces them with `auto` variables declared directly in loops.
Schematic::sizeOfSelection returns values back to the client via four reference variables passed to it as arguments. This is not very elegant and most important it doesn't convey return values semantics. This commit makes 'sizeOfSelection' return QRect as usual return value of function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
A bit of refactoring of one of the
Schematic's member functions. The main idea is to move the function from returning result via a set of argument reference variables to returning it the usual way, packed in suitable abstraction.Commits are logically independent and reasonably small, so I suggest reviewing them one by one.
The function is invoked only when "zoom to selection" is performed, so if there any bugs they will affect zooming.