Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for '_props.json' generation from osdi file. #630

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

onehebe
Copy link
Contributor

@onehebe onehebe commented Mar 7, 2024

The original '_props.json' generator would cause some troubles, especially when too many comments or macros were shown in the verilog-a code (like in cmc-recommend format).
The revised code provide a solution to obtain the correct values for parameter name/value/description from osdi interface.
When osdi file not exits, the json file will be generated following the old routine.

Signed-off-by: Linfeng He <akirt@outlook.com>
@ra3xdh
Copy link
Owner

ra3xdh commented Mar 8, 2024

Thanks for the contribution! This may resolve problems with JSON reported in #411. I would merge this. But I have no intention to further develop JSON approach for Verilog-A support, because it was designed for ADMS and has many disadvantages. The ADMS development has been discontinued. I have proposed a workflow without JSON files. See: #411 (comment) I have intention to implement a special file device which could automate this approach. But this is a low priority task for me because of low demand on compact modelling features among Qucs-S users.

@ra3xdh ra3xdh merged commit 19fa1d9 into ra3xdh:current Mar 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants