Plug diagram memory leak #1139
Merged
Plug diagram memory leak #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any of this related to #1127? I've modified the sub-circuits and schematic since and can get the circuits to simulate in a reasonable time without hogging all the resources. |
|
Thanks for finding this. Merged. |
ivandi69
pushed a commit
to ivandi69/qucs_s
that referenced
this pull request
Dec 17, 2024
Fixes a double free regression caused by ra3xdh#1139
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a memory leak in the diagram object. With big datasets the leak can be huge.
The attached schematic can be used to reproduce the problem and test the fix. Run the simulation and monitor Qucs-s memory usage. If the diagram is deleted or the schematic tab is closed the memory is not released. If the schematic is opened again or the diagram is deleted and added again the memory consumption increases further.
Diagram_Memory_Leak.sch.txt