Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save the position / size of ExternSimDialog on exit. #1028

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

iwbnwif
Copy link
Contributor

@iwbnwif iwbnwif commented Oct 26, 2024

This is a simple change to store the last used position and size of the "Simulate with external simulator" dialog (class ExternSimDialog) when the user presses the "Exit" button.

This change should close #1012 and work on all platforms but I have only tested it on Linux / Qt6.

@iwbnwif
Copy link
Contributor Author

iwbnwif commented Oct 26, 2024

@tomhajjar, @ainst please let me know if this addresses the issue.

@ra3xdh ra3xdh added this to the 24.4.0 milestone Oct 26, 2024
@ra3xdh
Copy link
Owner

ra3xdh commented Oct 27, 2024

I have tested this PR and noticed the following problem. When using Wayland+Qt6.7.2 the window size is restored, but the window position is not restored. The dialog always positioned in the display center. I am not sure if this is patch issue or Wayland issue. Wayland may not allow to set the initial position of the dialog windows. I didn't test Windows and X11.

@iwbnwif
Copy link
Contributor Author

iwbnwif commented Oct 27, 2024

Unfortunately, I cannot get Wayland to run well on my computer.

If you are using Gnome and have Gnome Tweaks installed, please can I ask you to check the setting Windows->Centre New Windows. The behavior of this setting appears to be different between X11 and Wayland.

@ra3xdh
Copy link
Owner

ra3xdh commented Oct 27, 2024

I am using KDE. The KDE has a similar setting but it seems it has no effect. Let's consider this as some KDE+Wayland bug or feature. I am merging this.

@ra3xdh ra3xdh merged commit e5be6e7 into ra3xdh:current Oct 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simulation console screen position
2 participants