Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matching Circuit Tool generates wrong results #905

Closed
tomhajjar opened this issue Aug 23, 2024 · 7 comments · Fixed by #907 or #909
Closed

Matching Circuit Tool generates wrong results #905

tomhajjar opened this issue Aug 23, 2024 · 7 comments · Fixed by #907 or #909
Assignees
Labels
Milestone

Comments

@tomhajjar
Copy link

tomhajjar commented Aug 23, 2024

Update:

The device seems to be marginally stable.
Project updated with all fixes

Follow up to #401, @andresmmera

In testing Matching Circuit Tool for an "L-section match" case, I found the component values to be unrealistic.

The input match L1 shunt inductor value of "0.000H" should be interpreted as a short to ground or possibly using "creative license", an open circuit to ground. The output match L4 series inductor value of "2.556H" can only be interpreted as an open circuit.

I didn't test any other cases since having to copy and paste S-parameter values becomes tedious and error prone.

2024-08-23_184159
2024-08-23_184019
2024-08-23_183704

BFP193W_amplifier_prj.zip

@andresmmera
Copy link
Collaborator

Hi @tomhajjar , thanks for pointing this out.

The device is not unconditionally stable and it cannot be conjugately matched. Equations 12.40a/b in [1] don't have a solution for this case since the argument of the square roots is negative.

image

image

I think that the best solution would be to check if the device is unconditionally stable here in order to avoid wrong results like this. I can write a fix for this later.

Schematic:
BFP193W_spar_analysis.zip

[1] Microwave Engineering. David M Pozar. 4th Edition. 2012

@ra3xdh ra3xdh added the RF label Aug 24, 2024
andresmmera added a commit to andresmmera/qucs_s that referenced this issue Aug 24, 2024
As reported in issue ra3xdh#905, the matching network tool gave wrong results when using a conditionally stable S-matrix. In order to have a conjugately match, the device is required to meet the unconditional stability criteria defined in [1] as K > 1 and abs(delta) < 1

A condition was added in the program to filter out these cases and warn the user against this limitation.

[1] Microwave Engineering. David M Pozar. 2012. Eqs 12.28 and 12.29
@tomhajjar
Copy link
Author

tomhajjar commented Aug 24, 2024

Not often a device's Spice model correlates so well with it's S-parameter data...

2024-08-24_085742
2024-08-24_085723

@tomhajjar
Copy link
Author

@andresmmera

One minor issue with the tool is if any entry or setting is "wrong" or out of bounds, a error message is shown and the tool is closed. Is there a way to allow the user to fix the wrong entry and not close the tool?

@andresmmera
Copy link
Collaborator

Good point. I'll take a look later.

@ra3xdh ra3xdh added this to the 24.4.0 milestone Aug 24, 2024
ra3xdh added a commit that referenced this issue Aug 24, 2024
…K_less_1

Fix issue #905 - The matching network tool gives incorrect results when conditionally stable data is provided
@ra3xdh
Copy link
Owner

ra3xdh commented Aug 24, 2024

Fixed by #907. Closing as completed.

andresmmera added a commit to andresmmera/qucs_s that referenced this issue Aug 24, 2024
A condition has been added to slotButtCreate() to keep the dialogue open in case the synthesis goes wrong. This allows the user to fix the input parameters as requested in issue ra3xdh#905.
@andresmmera
Copy link
Collaborator

@andresmmera

One minor issue with the tool is if any entry or setting is "wrong" or out of bounds, a error message is shown and the tool is closed. Is there a way to allow the user to fix the wrong entry and not close the tool?

Fixed in PR #909

@tomhajjar
Copy link
Author

This Qorvo tool is useful for seeing the effect of R on K.

2024-08-25_130123

@ra3xdh ra3xdh modified the milestones: 24.4.0, 24.3.1 Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment