Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lossless TLine netlist is wrong in some cases #602

Closed
tomhajjar opened this issue Feb 20, 2024 · 5 comments · Fixed by #610
Closed

Lossless TLine netlist is wrong in some cases #602

tomhajjar opened this issue Feb 20, 2024 · 5 comments · Fixed by #610

Comments

@tomhajjar
Copy link

tomhajjar commented Feb 20, 2024

The TLine netlist has unneeded entries confusing ngspice. You can't fix the problem setting a parameter value to "0" or " "

T1 1 2 3 4 Z0=50 Td=1ns -> good - Unfortunately Qucs will add "F=0"/"F=" and "NL=0"/"NL="

T1 1 2 3 4 Z0=50 F=1e9 NL=0.25 -> good - Unfortunately Qucs will add "Td=0"/"Td=" nullifying F and NL

T1 1 2 3 4 Z0=50 F=1e9 -> good - Unfortunately Qucs will add Td and NL nullifying F and NL

T1 1 2 3 4 Z0=50 Td=1ns F=0 NL=0 -> bad - If Td used, F and NL should not be in netlist

T1 1 2 3 4 Z0=50 Td=0 F=1e9 NL=0.25 -> bad - Td=0 will nullify F=1e9 NL=0.25

T1 1 2 3 4 Z0=50 Td=1ns F= NL= -> bad

One solution would be a blank entry would delete the item from the netlist.

2024-02-20_192412

2024-02-20_192432

2024-02-20_192449

Transmission_Line_prj.zip

@dwarning
Copy link

The attached patch file will solve the problems in tline parameter handling.
All examples show reasonable results.

Tline.patch.txt

@ra3xdh ra3xdh linked a pull request Feb 24, 2024 that will close this issue
@ra3xdh
Copy link
Owner

ra3xdh commented Feb 24, 2024

@dwarning Thanks for providing a patch. I have added your path as a part of #610

@ra3xdh ra3xdh closed this as completed Feb 24, 2024
@dwarning
Copy link

@ra3xdh Thank you.
But as mentioned in #601 the patch is only a workaround. qucs-s gui has to work as user of ngspice who take care for the both specification modes of tline: 1. Specify Td (F and Nl omitted) 2. Specify F and Nl (Td is omitted and not(!) given in netlist)

@tomhajjar
Copy link
Author

tomhajjar commented Feb 24, 2024

  1. Specify Z/Td (F and NL omitted and not(!) given in netlist) ngspice will ignore F/NL anyway
  2. Specify Z/F/NL (Td is omitted and not(!) given in netlist)
  3. Specify Z/F (Td AND NL is omitted and not(!) given in netlist) and ngspice -> NL=0.25

@tomhajjar
Copy link
Author

I revisited my project above and ngspice TLine is now working with ver 24.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants