Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

488 move parsing methods from host to api clients #503

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

maciekbanas
Copy link
Member

Closes #459
Closes #488

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 89.55696% with 33 lines in your changes missing coverage. Please review.

Project coverage is 70.91%. Comparing base (f53947e) to head (9defa4c).
Report is 5 commits behind head on devel.

Files with missing lines Patch % Lines
R/EngineRestGitLab.R 70.37% 16 Missing ⚠️
R/EngineGraphQLGitHub.R 95.28% 5 Missing ⚠️
R/EngineGraphQLGitLab.R 95.91% 4 Missing ⚠️
R/GitStats.R 60.00% 4 Missing ⚠️
R/GitHost.R 80.00% 2 Missing ⚠️
R/EngineRestGitHub.R 94.11% 1 Missing ⚠️
R/GitHostGitLab.R 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #503      +/-   ##
==========================================
- Coverage   70.92%   70.91%   -0.01%     
==========================================
  Files          17       17              
  Lines        3061     3067       +6     
==========================================
+ Hits         2171     2175       +4     
- Misses        890      892       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maciekbanas maciekbanas marked this pull request as ready for review October 15, 2024 12:34
@maciekbanas maciekbanas merged commit bb02627 into devel Oct 15, 2024
9 checks passed
@maciekbanas maciekbanas deleted the 488-move-parsing-methods-from-host-to-api-clients branch October 15, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move parsing methods from host to api clients Use tibble as output everywhere
2 participants