Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

341 fix and speed up pulling package usage #344

Conversation

maciekbanas
Copy link
Member

No description provided.

@maciekbanas maciekbanas requested a review from Cotau December 19, 2023 11:31
@maciekbanas maciekbanas self-assigned this Dec 19, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2023

Codecov Report

Attention: 209 lines in your changes are missing coverage. Please review.

Comparison is base (1081673) 75.40% compared to head (b55177b) 84.59%.
Report is 194 commits behind head on devel.

❗ Current head b55177b differs from pull request most recent head 14cd0e3. Consider uploading reports for the commit 14cd0e3 to get more accurate results

Files Patch % Lines
R/GitHost.R 79.14% 44 Missing ⚠️
R/EngineGraphQLGitLab.R 78.31% 36 Missing ⚠️
R/EngineRestGitHub.R 81.25% 33 Missing ⚠️
R/EngineGraphQLGitHub.R 79.85% 27 Missing ⚠️
R/EngineRestGitLab.R 75.75% 24 Missing ⚠️
R/GitStats.R 88.57% 16 Missing ⚠️
R/GQLQueryGitHub.R 72.00% 14 Missing ⚠️
R/GQLQueryGitLab.R 88.63% 10 Missing ⚠️
R/gitstats_functions.R 87.50% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #344      +/-   ##
==========================================
+ Coverage   75.40%   84.59%   +9.19%     
==========================================
  Files          12       15       +3     
  Lines         992     1948     +956     
==========================================
+ Hits          748     1648     +900     
- Misses        244      300      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maciekbanas maciekbanas changed the title 341 when running multiple pull r package use use pulled files 341 fix and speed up pulling package usage Dec 28, 2023
…ctor check_package_as_dependency. Refactoring of the function is swithcing totally to search rest api with filtering response by files (NAMESPACE, DESCRIPTION) instead of pulling them in separate process which was very time consuming. Fixing pulling files for setup repositories (i.e. when they are used instead of pulling new) is a side-effect of earlier tries to optimize the check_package_as_dependency function. This feature is not now used in the function, but it may be helpful in future developments.
@maciekbanas maciekbanas merged commit 24c83be into devel Dec 29, 2023
2 checks passed
@maciekbanas maciekbanas deleted the 341-when-running-multiple-pull_r_package_use-use-pulled-files branch December 29, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants