-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
326 new search package usage function #327
Conversation
… importantly, a message handler has been added to tackle 403 error on public GitHub side. Also, a new `silence` parameter has been added, as a new function is simply a wrapper over existing ones, and calling it with all the messages would be superfluous. Some optimization in expect-tests.
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## devel #327 +/- ##
==========================================
+ Coverage 75.40% 84.05% +8.64%
==========================================
Files 12 15 +3
Lines 992 1837 +845
==========================================
+ Hits 748 1544 +796
- Misses 244 293 +49 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to be runing nice, but I did encounter some errors, when following your workflow:
timeouts when scraping open repositories, I assume that this was to be expected but is there a way of extending timeouts or perhaps running it in chunks so that the code won't miss any important information?
`> check_package_usage(
- test_gitstats,
- "purrr" #enter a name of a package you want to search for
- )
ℹ Checking [purrr] package usage across repositories...
ℹ HTTP 403 error: I will run request one more time after 60 secs...
HTTP 403 API limit reached. 25% | ETA: 1m
HTTP 400 Bad Request.■■■ 75% | ETA: 1m`
While running the code for internal repositories I also got some errors:
ℹ Checking [R****Templates] package usage across repositories... Empty object - will not be saved. 75% | ETA: 2m
what's more, while checking results it showed some repositories that were not updated since 2019 or 2020 which is long before "R****Templates" was introduced. Is that a logic error to be taken care of, or is it something regular here? if so should we cover it with some additional explanation?
…y errors), fixing search responses, changing logic of checking usage of a package (two separate functions); also as a side effect of previous attempts add possibility to pull files on given repos (although it is not used now, it may be in the future). Additionaly remove `silence` field from settings as there is no need to use it, change name of check_package to check_R_package.
@@ -256,6 +292,11 @@ GitStats <- R6::R6Class("GitStats", | |||
private$files | |||
}, | |||
|
|||
#' @description Return R_package_usage table from GitStats. | |||
get_R_package_usage = function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would create an output in more user friendly form as api links are not straightforward readable. I would add links to the repositories and repo names. Other than this it seems that the amuont of output is reasonable but that is to bu further investigation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change the output of this search more user friendly
…me columns of repository output to standardize with files output. Add pulling files by repositories option to GitLab which was missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
No description provided.