Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some procesess to GitHost subclasses #367

Closed
maciekbanas opened this issue Feb 16, 2024 · 2 comments
Closed

Move some procesess to GitHost subclasses #367

maciekbanas opened this issue Feb 16, 2024 · 2 comments
Assignees
Labels
OOP Refers to good OOP practice refactor Refactor code

Comments

@maciekbanas
Copy link
Member

This issue somehow reverts to previous GitStats architecture, where GitHub and GitLab classes existed as subclasses of GitHost. This architecture seemed complex, as it introduced an addittional layer to GitStats logic.
Nonetheless, it had one big advantage: managing on git platform level which engine to choose when process of getting data is divided between two engines, e.g.:

  • pulling commits response via GraphQL, but organizing commits authors logins and names via REST.
  • pulling repositories via GraphQL, but repos contributors via REST.

Summing up, although structure of classes grows, the process of pulling data will be constructed through readable "bricks".

@maciekbanas maciekbanas added refactor Refactor code OOP Refers to good OOP practice labels Feb 16, 2024
@maciekbanas maciekbanas added this to the 2.0.0 milestone Feb 16, 2024
@maciekbanas maciekbanas self-assigned this Feb 16, 2024
@maciekbanas
Copy link
Member Author

Some examples to move:

  • setting up engines

@maciekbanas maciekbanas removed this from the 2.0.0 milestone Mar 20, 2024
@maciekbanas
Copy link
Member Author

Developed in #383

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OOP Refers to good OOP practice refactor Refactor code
Projects
None yet
Development

No branches or pull requests

1 participant