Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infinite loop for bad request error handling #360

Closed
maciekbanas opened this issue Jan 26, 2024 · 2 comments
Closed

Infinite loop for bad request error handling #360

maciekbanas opened this issue Jan 26, 2024 · 2 comments
Labels
bugfix Something isn't working

Comments

@maciekbanas
Copy link
Member

FYI @marcinkowskak
Issues with running storage.R for pull_commits() function - for GitLab when it encounters Error with bad request, the function is running in the infinite loop.
@maciekbanas maciekbanas added the bugfix Something isn't working label Jan 26, 2024
@maciekbanas maciekbanas added this to the 2.0.0 milestone Jan 26, 2024
@maciekbanas
Copy link
Member Author

The core of the problem lies in helper date_to_gts which used stringr - different version of package checked probably differently str_length of date.

@maciekbanas maciekbanas removed this from the 2.0.0 milestone Mar 20, 2024
@maciekbanas
Copy link
Member Author

Done in #374

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bugfix Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@maciekbanas