Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qgis_sanitize_arguments(): fix loss of special arguments #79

Merged
merged 3 commits into from
Jan 21, 2022

Conversation

florisvdh
Copy link
Member

This tries to solve #75. Because in qgis_sanitize_arguments(), the step that matches user arguments against algorithm arguments drops the special ELLIPSOID and PROJECT_PATH arguments, the latter were not passed to the qgis_process command.

@ThierryO can you give this a try?

@florisvdh
Copy link
Member Author

Reasoning of 7d98d41:

named_empty_list <- rlang::set_names(list(), character())
named_empty_list
#> named list()
c(named_empty_list, named_empty_list)
#> list()

Created on 2022-01-21 by the reprex package (v2.0.1)

@paleolimbot
Copy link
Collaborator

Thank you!

If it's easy to add a test for this (test_that("qgis_sanitize_arguments() doesn't drop special arguments", { ... }), could you do that here?

@florisvdh
Copy link
Member Author

Tried that with 0b86162!

@paleolimbot
Copy link
Collaborator

This looks great! Thank you!

@paleolimbot paleolimbot merged commit 3768999 into r-spatial:master Jan 21, 2022
@florisvdh florisvdh mentioned this pull request Jan 26, 2022
@florisvdh florisvdh deleted the special_args branch January 26, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants