Support for single sc_ops
for faster specific method in ssesolve
and smesolve
#408
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Thank you for contributing to
QuantumToolbox.jl
! Please make sure you have finished the following tasks before opening the PR.make test
.julia
formatted by running:make format
.docs/
folder) related to code changes were updated and able to build locally by running:make docs
.CHANGELOG.md
should be updated (regarding to the code changes) and built by running:make changelog
.Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.
Description
The current implementation of
ssesolve
andsmesolve
only supportssc_ops
to be either aVector
or aTuple
.This constraints the solver to use the non-diagonal noise, as the diagonal one can only be implemented in the case of a single collapse operator. This cannot be inferred automatically, as the solver may depend on the length of
sc_ops
, creating type instability.Here I implement the support for a single
AbstractQuantumObject
, which allows to implement the diagonal noise through multiple dispatch, thus without giving type instabilities.The performances are 4 times better with respect to using a
Vector
of length one.