Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap callback patch #101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

swap callback patch #101

wants to merge 1 commit into from

Conversation

ernstnaezer
Copy link

Added callback support for the swap function, this allows code to be executed after a fadeout / fadein sequence when the html is in place.

…executed after a fadeout / fadein sequence when the html is in place.
@quirkey
Copy link
Owner

quirkey commented Nov 15, 2011

I want to take this work in, but you need to do a bunch of cleanup first. First of all, fix up all the spacing so its consistent. This project uses 2 soft-tabs (spaces) for indentation. Also, for the benefit of consistency and linting, please wrap all if statements in {}. Additionally, it would be great to get some even very simple tests for this in the test suite, especially with the code related to partial() since thats such an overloaded method already.

Thanks!

quirkey pushed a commit that referenced this pull request Jan 22, 2012
Based on enix's patch, cleaned it up and fixed a couple minor issues
@s7726
Copy link

s7726 commented May 26, 2018

@quirkey Looks like you merged in an equivalent commit. Can we get this pull request closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants