Introduce tests to run after upgrade #561
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #561 +/- ##
=======================================
Coverage 77.13% 77.13%
=======================================
Files 7 7
Lines 726 726
=======================================
Hits 560 560
Misses 166 166 ☔ View full report in Codecov by Sentry. |
mirekdlugosz
force-pushed
the
post-upgrade-tests
branch
from
4d78a2e to
0c94575
Compare
These tests focus around the question: if I upgrade Quipucords to newest version, can I still use it? They modify existing data, reuse it and create brand new data. Data reading is covered by snapshot tests, as creating a new snapshot fundamentally reads the data through API.
mirekdlugosz
force-pushed
the
post-upgrade-tests
branch
from
0c94575 to
155a1b2
Compare
bruno-fs
reviewed
Feb 20, 2025
Comment on lines
+745
to
+748
| credential = random.choice(all_credentials) | ||
| credential_name = credential.get("name") | ||
| if not credential.get("username"): | ||
| pytest.skip("Credential does not store username") |
There was a problem hiding this comment.
I'm probably missing context here, but I'm under the impression we might want to only skip if no credentials have username. I suggest we randomly select from credentials pre-filtered, with the filter being "credential has username key". If not credentials match this criteria, then we skip.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests focus around the question: if I upgrade Quipucords to newest version, can I still use it?
They modify existing data, reuse it and create brand new data. Data reading is covered by snapshot tests, as creating a new snapshot fundamentally reads the data through API.
This PR includes #560 and will be rebased after the other one is merged. I included #560 to avoid conflicts.
Some of the new tests would end up being run by PR pipeline, which is not what we want. This will be fixed on discovery-ci side in next step.