Custom policy warning #4379
Custom policy warning #4379
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds a warning message when users create custom policies and enhances documentation for the ManagedUserRoleExtraPolicies parameter.
- Added a warning in
catalog/app/containers/Admin/UsersAndRoles/Policies.tsxthat informs users they need to add custom policy ARNs to ManagedUserRoleExtraPolicies - Added a documentation link to the technical reference within the warning message
- Created a dedicated section in
docs/technical-reference.mdfor ManagedUserRoleExtraPolicies parameter - Moved existing reference to this parameter from SSE-KMS section to its own section for better visibility
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4379 +/- ##
===========================================
+ Coverage 38.68% 91.47% +52.78%
===========================================
Files 795 108 -687
Lines 35186 10007 -25179
Branches 5377 0 -5377
===========================================
- Hits 13613 9154 -4459
+ Misses 21027 853 -20174
+ Partials 546 0 -546
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
docs/technical-reference.md
Outdated
| @@ -550,6 +550,19 @@ Note the comma after the object. Your trust relationship should now look somethi | |||
|
|
|||
| You can now configure a Quilt Role with this role (using the Catalog's admin panel, or `quilt3.admin.create_role`). | |||
|
|
|||
| ### ManagedUserRoleExtraPolicies | |||
|
|
|||
| The `ManagedUserRoleExtraPolicies` parameter allows you to add additional IAM policies to the managed user role. This is useful for granting additional permissions to users in your Quilt instance, which otherwise would be blocked by the permission boundary. | |||
There was a problem hiding this comment.
IMO it's not quite clear that you need both to modify ManagedUserRoleExtraPolicies and add policy in Quilt Admin
There was a problem hiding this comment.
This applies to more than just User Policies (see KMS below). I will add clarifying text, though.
Description
Warn users when adding a custom policy.
Point to (new) docs about ManagedUserRoleExtraPolicies
TODO