fix clippy #2588
Open
fix clippy #2588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PSeitz
force-pushed
the
clippy
branch
2 times, most recently
from
ef87e56 to
b01b8e0
Compare
fulmicoton
reviewed
Mar 7, 2025
| @@ -48,7 +48,7 @@ impl BitPacker { | |||
|
|
|||
| pub fn flush<TWrite: io::Write + ?Sized>(&mut self, output: &mut TWrite) -> io::Result<()> { | |||
| if self.mini_buffer_written > 0 { | |||
| let num_bytes = (self.mini_buffer_written + 7) / 8; | |||
| let num_bytes = self.mini_buffer_written.div_ceil(8); | |||
There was a problem hiding this comment.
Here it does not matter, but this has a small micro impact on performance.
There was a problem hiding this comment.
ah good to know, I thought it would lead to the same instruction
fulmicoton
reviewed
Mar 7, 2025
bitpacker/src/bitpacker.rs
Outdated
| @@ -65,7 +65,7 @@ impl BitPacker { | |||
|
|
|||
| #[derive(Clone, Debug, Default, Copy)] | |||
| pub struct BitUnpacker { | |||
| num_bits: usize, | |||
| num_bits: u32, | |||
fulmicoton
reviewed
Mar 7, 2025
bitpacker/src/blocked_bitpacker.rs
Outdated
| @@ -34,7 +34,7 @@ struct BlockedBitpackerEntryMetaData { | |||
|
|
|||
| impl BlockedBitpackerEntryMetaData { | |||
| fn new(offset: u64, num_bits: u8, base_value: u64) -> Self { | |||
| let encoded = offset | (u64::from(num_bits) << (64 - 8)); | |||
| let encoded = offset | ((num_bits as u64) << (64 - 8)); | |||
fulmicoton
requested changes
Mar 7, 2025
Yes, a failed rebase. I restarted from scratch instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.