Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sexpconv package refactoring #111

Open
quasilyte opened this issue Jul 24, 2017 · 0 comments
Open

sexpconv package refactoring #111

quasilyte opened this issue Jul 24, 2017 · 0 comments
Assignees
@quasilyte
Labels
refactoring
Milestone
PreRelease2

Comments

@quasilyte
Copy link
Owner

quasilyte commented Jul 24, 2017 •
edited
Loading

This refactoring was planned long ago.

Plan:

  • Decompose converter functions (it does too much at the moment).
  • Change converter type to conversion context (like in compiler package)
  • Improve error reporting (replace errors without file info)

#25 should also be fixed along the way.
@quasilyte quasilyte added this to the PreRelease2 milestone Jul 24, 2017
@quasilyte quasilyte self-assigned this Jul 24, 2017
quasilyte added a commit that referenced this issue Jul 24, 2017
@quasilyte
refs #111 - using map of types for typeCast expressions; this is a st…
195dc3c 
…ep towards bigger change
quasilyte added a commit that referenced this issue Jul 24, 2017
@quasilyte
refs #111 - sexpConst as a replacement for "constant.go"
4ba68e4
quasilyte added a commit that referenced this issue Jul 25, 2017
@quasilyte
refs #111 - renaming lisp.Func field Sym to Name
98f1cbe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quasilyte quasilyte

Labels
refactoring
Projects
None yet
Milestone
PreRelease2
Development

No branches or pull requests
1 participant
@quasilyte