within citations, if page is undefined do not make it a string

[cderv]

This would have the side effect of having the undefined field shows in output

Fixes #7638 following change in 2e7ba02

cc @dragonstyle

[kdheepak]

Thanks for the quick PR!

The function you modified returns this:

  return {
    firstPage: firstPage as string,
    lastPage: lastPage as string,
    page: pages,
  };

but firstPage and lastPage may also be undefined, right? Wouldn't you need to do a similar check for those two lines?

Alternatively, do it in the first couple of lines and return this instead:

  return {
    firstPage,
    lastPage,
    page: pages,
  };

[cderv]

Thanks for chiming in.

I don't think we need it because

> undefined as string
undefined
> `${ undefined}` as string
"undefined"

For pages we added in 2e7ba02 the special treatment of passing to a string using `${ var }` syntax. And this was the syntax that make undefined become a string as "undefined" instead of staying undefined. Other variables do not have that treatment

[dragonstyle]

sweet