Fix regression on Docx Layout for non float elements #7636
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #7624
I believe this should be how to support non float element, based on what we do for html panelLayout.
Though a question: Should non float layout be tested with
layout.float == nil
orlayout.is_float_reftarget == false
?It seems we do both.
I added a test for docx floatless panel layout. Oddly we did not had one yet 🤷♂️