Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a .editorconfig file #7081

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mhucka
Copy link
Contributor

@mhucka mhucka commented Feb 23, 2025

This adds settings based on some common-sense values and the Cirq project's current conventions, such as line length and use of spaces instead of tabs.

This resolves #6998.

This adds settings based on some common-sense values and the Cirq
project's current conventions, such as line length and use of spaces
instead of tabs.
@CirqBot CirqBot added the size: S 10< lines changed <50 label Feb 23, 2025
@mhucka mhucka marked this pull request as ready for review February 23, 2025 06:08
@mhucka mhucka requested review from vtomole and a team as code owners February 23, 2025 06:08
@mhucka mhucka requested a review from maffoo February 23, 2025 06:08
@mhucka mhucka enabled auto-merge February 23, 2025 06:08
@mhucka mhucka self-assigned this Feb 23, 2025
@mhucka mhucka added the kind/health For CI/testing/release process/refactoring/technical debt items label Feb 23, 2025
Copy link

codecov bot commented Feb 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.18%. Comparing base (a2bf6e8) to head (5fdf996).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7081      +/-   ##
==========================================
- Coverage   98.18%   98.18%   -0.01%     
==========================================
  Files        1089     1089              
  Lines       95237    95237              
==========================================
- Hits        93508    93507       -1     
- Misses       1729     1730       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mhucka mhucka changed the title Resolve #6998: add a .editorconfig file Add a .editorconfig file Feb 23, 2025
Comment on lines +17 to +18
# Important setting: trailing whitspace is meaningful in Markdown.
trim_trailing_whitespace = false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please comment when is this needed?

My impression was that trailing spaces in md were basically a noise that would be better removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/health For CI/testing/release process/refactoring/technical debt items size: S 10< lines changed <50
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a .editorconfig file
3 participants