Miscellaneous tiny shell script tweaks #7080
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the added `.shellcheckrc` options of PR quantumlib#7079, the `shellcheck` program flagged a couple of places where the effects of the `set -e` at the beginning of this script would not have the expected effect.
Ignore a few more extensions when creating a list of candidate files to test for being shell scripts.
The `typeset` command is considered obsolete; `declare` is its replacement. While this is not specifically related to the problem of the "ambiguous redirect", it helps to make sure the use of `typeset` wasn't a factor.
Some uppercase VARIABLE names in this file are inconsistent in style with what's done in other files.
mhucka
force-pushed
the
mh-tiny-shell-script-tweaks
branch
from
7deff0d to
c6246ac
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7080 +/- ##
=======================================
Coverage 98.18% 98.18%
=======================================
Files 1089 1089
Lines 95237 95237
=======================================
Hits 93508 93508
Misses 1729 1729 ☔ View full report in Codecov by Sentry. |
This adds declarations to more variables used in the shell scripts.
Some script used a mix of `[...]` and `[[...]]` for no apparent reason. It would be better for maintainability to consistently use one or the other. Since the scripts all explicitly use Bash, we may as well use `[[...]]` throughout.
mhucka
force-pushed
the
mh-tiny-shell-script-tweaks
branch
from
c6246ac to
508720c
Compare
mhucka
added
the
kind/health
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
shellcheckraised a couple of warnings in some scripts; this commit addresses them, and also addresses a few other niggles here and there.set -eat the top of a script would be ignored inside$(...)constructstypesettodeclare, because the former is considered obsoletedeclareall variables[[ ... ]]consistently instead of a mix of[...]and[[...]]