Support parameters in InternalTag #7060
Merged
+17
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dstrain115
commented
Feb 12, 2025
dstrain115
commented
- This adds support for parameters in InternalTag.
- This adds support for parameters in InternalTag.
dstrain115
requested review from
wcourtney,
vtomole,
verult and
a team
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7060 +/- ##
=======================================
Coverage 98.18% 98.18%
=======================================
Files 1089 1089
Lines 95202 95244 +42
=======================================
+ Hits 93473 93515 +42
Misses 1729 1729 ☔ View full report in Codecov by Sentry. |
pavoljuhas
reviewed
Feb 21, 2025
|
|
||
| kw_dict = {} | ||
| for k, v in msg.internal_tag.tag_args.items(): | ||
| kw_dict[k] = arg_func_langs.arg_from_proto(v, arg_function_language='exp') |
There was a problem hiding this comment.
Should we set arg_function_language also in the to_proto method above at line 71?
Also, let us do the msg.WhichOneof check (L83) first before building kw_dict.
pavoljuhas
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.