-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare v5.0.0 Release #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remote-method-guesser now attempts to create missing socket factory classes dynamically.
Added a spring remoting server.
First working draft.
When using remote-method-guessers ysoserial integration, gadget objects created by ysoserial were annotated by the marshaloutput stream. This annotation included the absoulte file system path of the ysoserial library, which represents a low impact information disclosure. Since remote-method-guesser already overrides the default RMIClassLoader, this behavior was now changed by always returning null as result of the getClassAnnotation method.
A new RemoteObject was added to port 9010 of the ExampleServer. This remote object is registred with a custom RMISocketFactory to allow tests of the dynamic SockerFactory creation feature of remote-method-guesser.
The GenericPrint plugin is now included into rmg per default and can be activated by using the --return-value option.
Switch namespace from de.qtc to eu.tneitzel. The initial namespace was chosen without further thinking about it. From version v5.0.0 it is planned to expose remote-method-guesser also via maven repositories. Therefore, we switch now to a namespace that is actually owned by the author.
Related to #52
When remote-method-guesser performs a lookup operation, classes may be created dynamically to handle custom socket factories or RMI stubs. The serialVersionUid of these classes need to match the incomming class. remote-method-guesser hadles this using an error based appraoch, where the required serialVersionUid is obtained from an exception message. Up to this commit, the above mentioned mechanism only triggered once. This causes problems if you have e.g. a RMI stub class that uses a custom socket factory too. With this commit, the count is increased to five (probably more than required, but it won't hurt).
In some configurations, stream corruptions can occur during method guessing with multiple threads. This behavior seems to be non deterministically and was not fully understood yet. However, even on affected configurations, the miss rate is roughly at 1/3000 methods that fail. For this reason, we catch the resulting exceptions for now and only display warnings if running in verbose mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Changed
de.qtc
toeu.tneitzel
--verbose
is used