Skip to content

Commit

Permalink
qt-ui: Use better function names
Browse files Browse the repository at this point in the history
* Use `getQtCustomDesignerPath()` instead of `getDesignerPath()` which
is better naming

Change-Id: I2361f22213af7cdc0536b02d4079457b71683dee
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
  • Loading branch information
OrkunTokdemir committed Aug 9, 2024
1 parent b8493be commit dd9ba86
Showing 1 changed file with 4 additions and 12 deletions.
16 changes: 4 additions & 12 deletions qt-ui/src/project.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,7 @@ export class UIProject implements ProjectBase {
readonly _context: vscode.ExtensionContext
) {
this._designerServer = new DesignerServer();
this._customWidgetsDesignerExePath = getConfig<string>(
CONF_CUSTOM_WIDGETS_DESIGNER_EXE_PATH,
'',
this._folder
);
this._customWidgetsDesignerExePath = this.getQtCustomDesignerPath();
logger.info(
`${CONF_CUSTOM_WIDGETS_DESIGNER_EXE_PATH}: "${this._customWidgetsDesignerExePath}"`
);
Expand All @@ -57,11 +53,7 @@ export class UIProject implements ProjectBase {
this._folder
)
) {
this._customWidgetsDesignerExePath = getConfig<string>(
CONF_CUSTOM_WIDGETS_DESIGNER_EXE_PATH,
'',
this._folder
);
this._customWidgetsDesignerExePath = this.getQtCustomDesignerPath();
logger.info(
`new ${CONF_CUSTOM_WIDGETS_DESIGNER_EXE_PATH}:`,
this._customWidgetsDesignerExePath
Expand All @@ -83,15 +75,15 @@ export class UIProject implements ProjectBase {
if (this._designerClient) {
this._designerClient.detach();
this._designerClient = new DesignerClient(
this.getQtDesignerPath(),
this.getQtCustomDesignerPath(),
this._designerServer.getPort()
);
}
}
}
});
}
getQtDesignerPath() {
getQtCustomDesignerPath() {
return getConfig<string>(
CONF_CUSTOM_WIDGETS_DESIGNER_EXE_PATH,
'',
Expand Down

0 comments on commit dd9ba86

Please sign in to comment.