Make doNotAskForDefaultQtFolder a config variable

Storing that value in global `settings.json` is better than storing in
`StateManager` because when a config variable is used, users can copy
their configuration easily. That is not possible when it is stored in
`StateManager`.

Change-Id: I70cb712f0ec5296e427dc9aa8987b5e7d4612a5b
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>

package.json

@@ -255,6 +255,12 @@
           "default": "",
           "description": "Specify the Qt folder",
           "scope": "machine"
+        },
+        "vscode-qt-tools.doNotAskForDefaultQtFolder": {
+          "type": "boolean",
+          "default": false,
+          "description": "Do not ask for default Qt folder",
+          "scope": "machine"
         }
       }
     }

src/commands/register-qt-path.ts

@@ -87,8 +87,26 @@ export function getQtFolder(): string {
   );
 }
 
+export async function setDoNotAskForDefaultQtFolder(value: boolean) {
+  await vscode.workspace
+    .getConfiguration('vscode-qt-tools')
+    .update(
+      'doNotAskForDefaultQtFolder',
+      value,
+      vscode.ConfigurationTarget.Global
+    );
+}
+
+export function getDoNotAskForDefaultQtFolder(): boolean {
+  return (
+    vscode.workspace
+      .getConfiguration('vscode-qt-tools')
+      .get<boolean>('doNotAskForDefaultQtFolder') ?? false
+  );
+}
+
 export function checkDefaultQtFolderPath() {
-  if (!stateManager.getAskForDefaultQtFolder()) {
+  if (getDoNotAskForDefaultQtFolder()) {
     return;
   }
 
@@ -122,7 +140,7 @@ export function checkDefaultQtFolderPath() {
       if (response === setDefaultPathButtonMessage) {
         void setQtFolder(defaultPath);
       } else if (response === doNotShowAgainButtonMessage) {
-        void stateManager.setAskForDefaultQtFolder(false);
+        void setDoNotAskForDefaultQtFolder(true);
       }
     });
 }

src/commands/reset-qt-ext.ts

@@ -3,11 +3,12 @@
 
 import * as vscode from 'vscode';
 import { stateManager } from '../state';
-import { setQtFolder } from './register-qt-path';
+import { setDoNotAskForDefaultQtFolder, setQtFolder } from './register-qt-path';
 
 export async function resetQtExt() {
   await stateManager.reset();
   await setQtFolder('');
+  await setDoNotAskForDefaultQtFolder(false);
 }
 
 export function registerResetQtExtCommand() {

src/state.ts

@@ -30,15 +30,8 @@ export class StateManager {
   public setQtInstallations(value: string[]): Thenable<void> {
     return this._update('qtInstallations', value);
   }
-  public setAskForDefaultQtFolder(value: boolean): Thenable<void> {
-    return this._update('askForDefaultQtFolder', value);
-  }
-  public getAskForDefaultQtFolder(): boolean {
-    return this._get<boolean>('askForDefaultQtFolder', true);
-  }
   public async reset() {
     await this.setQtInstallations([]);
-    await this.setAskForDefaultQtFolder(true);
   }
 }