Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for devcontainers. #6

Merged
merged 5 commits into from
Feb 23, 2024
Merged

Add support for devcontainers. #6

merged 5 commits into from
Feb 23, 2024

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Feb 20, 2024

Description

Creation command is a bit long, but it does the job.
Allows for the use of GitHub Codespaces to do compilation online, rather than setting up a local environment.

@tzarc tzarc requested a review from a team February 20, 2024 05:31
@drashna
Copy link
Member

drashna commented Feb 20, 2024

Testing this out, noticed the qmk firmware folder. We might want to handle the qmk_firmware directory better. Eg, init it as a submodule or add it to gitignore, or something.

@tzarc
Copy link
Member Author

tzarc commented Feb 21, 2024

@drashna how about now? Not sold on the new code workspace file being created, but it allows for both qmk_userspace and qmk_firmware in the sidebar.

@drashna
Copy link
Member

drashna commented Feb 21, 2024

It looks like the code workspace doesn't get loaded unless you manually load it. Which, you could just add a folder to the workspace, anyways.

And a short look shows that there isn't a good solution for this :/

I'd say just opt to not add the workspace creation.

@tzarc
Copy link
Member Author

tzarc commented Feb 22, 2024

Yeah I came to the same conclusion. I've removed the automatic workspace generation, and sync'ed up the VSCode extensions with qmk/qmk_firmware.

"xaver.clang-format",
"llvm-vs-code-extensions.vscode-clangd",
"bierner.github-markdown-preview",
"donjayamanne.git-extension-pack"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VS Code recommended the dev/remote containers extension on first setup, for me. Not sure if we want/need it here.

				"ms-vscode-remote.remote-containers"

@tzarc tzarc merged commit 67fac78 into main Feb 23, 2024
2 checks passed
@tzarc tzarc deleted the devcontainer branch February 23, 2024 11:35
hdyson pushed a commit to hdyson/qmk_userspace that referenced this pull request Apr 6, 2024
kroleg pushed a commit to kroleg/qmk_keymaps that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants