Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Framework's touchpad.
Description
I wanted to add support for framework's touchpad but since qmk doesn't currently have system for that, it needed to be added. Now, I understand that the changes I've made won't be merged as-is, but instead I hope to establish conversation, so that I can refine them into what is acceptable. The changes I've made are framework-specific, and to add touchpad support that should be more generic.
Now issue with making generic system for touchpads is that each touchpad has its own descriptor, and easiest way of implementing touchpad is adding its own descriptor and just forwarding data we get from i2c, without parsing, without modifying anything since each touchpad has its own quirks that are handled on the OS side.
From what I've seen currently qmk generates descriptor depending on device configuration, and for touchpad, we would have to allow drivers to declare their descriptor, which is not impossible just something to be aware of.
Most touchpads are using i2c but if they're using something else that would also have to be taken into account.
So the simplest implementation of i2c touchpad driver is really just the descriptor, and in the core we can do entire communication over i2c which is just pass-through of data.
Also in
tmk_core/protocol/usb_descriptor.c:1261
I didn't know what the code does as I don't have much experience with USB so i piggy-backed on digitizer and it seems to work fine.I also haven't added any documentation because the code will surely change.
So please advise so that I can refine the code into something acceptable.
Types of Changes
Issues Fixed or Closed by This PR
Checklist