Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azoteq - improve I2C behaviour while polling. #24611

Merged
merged 2 commits into from
Jan 11, 2025
Merged

Azoteq - improve I2C behaviour while polling. #24611

merged 2 commits into from
Jan 11, 2025

Conversation

daskygit
Copy link
Member

Description

This aims to improve the behaviour when not using a motion pin. Using basic_profiling.h seems to have a fairly decent speed increase as less time is spent during I2C transactions.

Tweaked code
get_report -- Percentage time spent: 2% (idle)
get_report -- Percentage time spent: 2% (circle motion)


Old code
get_report -- Percentage time spent: 12% (idle)
get_report -- Percentage time spent: 63% (circle motion)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Nov 17, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jan 2, 2025
@drashna drashna requested a review from a team January 2, 2025 07:17
@drashna drashna added awaiting review breaking_change_2025q1 Targeting breaking changes Q1 2025 and removed stale Issues or pull requests that have become inactive without resolution. labels Jan 2, 2025
ilc added a commit to ilc/vial-qmk that referenced this pull request Jan 2, 2025
@ilc
azoteq: Fix the odd azoteq behavior.
b81811a 
Not sure why old units did not show this random pressing
of mouse 2 bug.  This port of:

qmk/qmk_firmware#24611

Fixes it.

Added axis code to make scroll more sane.
@idank
Copy link
Contributor

idank commented Jan 8, 2025

This change also fixes a bug with the current driver where it mistakenly reads a double tap gesture on every report. Seems to be happening on newer Azoteqs only.

+1 to merging this.

KarlK90
KarlK90 requested changes Jan 8, 2025
View reviewed changes
@daskygit @KarlK90
Update drivers/sensors/azoteq_iqs5xx.c
02653c7 
Co-authored-by: Stefan Kerkmann <karlk90@pm.me>
@daskygit daskygit requested a review from KarlK90 January 9, 2025 23:57
@drashna drashna merged commit 62e9832 into qmk:develop Jan 11, 2025
3 checks passed
yeroca pushed a commit to yeroca/qmk_firmware that referenced this pull request Jan 12, 2025
@daskygit @KarlK90
Azoteq - improve I2C behaviour while polling. (qmk#24611)
be89530 
Co-authored-by: Stefan Kerkmann <karlk90@pm.me>
alinelena pushed a commit to alinelena/qmk_firmware that referenced this pull request Feb 3, 2025
@daskygit @KarlK90 @alinelena
Azoteq - improve I2C behaviour while polling. (qmk#24611)
e102314 
Co-authored-by: Stefan Kerkmann <karlk90@pm.me>
SiriusStarr pushed a commit to SiriusStarr/svalboard-vial-qmk that referenced this pull request Feb 5, 2025
@ilc @SiriusStarr
azoteq: Fix the odd azoteq behavior.
39064f5 
Not sure why old units did not show this random pressing
of mouse 2 bug.  This port of:

qmk/qmk_firmware#24611

Fixes it.

Added axis code to make scroll more sane.
ilc added a commit to svalboard/vial-qmk that referenced this pull request Feb 11, 2025
@ilc
azoteq: Fix the odd azoteq behavior.
4808584 
Not sure why old units did not show this random pressing
of mouse 2 bug.  This port of:

qmk/qmk_firmware#24611

Fixes it.

Added axis code to make scroll more sane.
@daskygit daskygit deleted the pr/azoteq_tweaks branch February 19, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@KarlK90 KarlK90 KarlK90 approved these changes

Assignees
No one assigned
Labels
awaiting review breaking_change_2025q1 Targeting breaking changes Q1 2025 core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daskygit @idank @drashna @KarlK90