fix: fix maxAge in express

qiqiboy · Sep 13, 2024 · b90228a · b90228a
1 parent cbf6da7
commit b90228a
Show file tree

Hide file tree

Showing 4 changed files with 32 additions and 4 deletions.
diff --git a/dist/server.cjs.js b/dist/server.cjs.js
@@ -210,9 +210,17 @@ function setCookie(name, val, options) {
   } = asyncLocalStorage.getStore() || {};
   if (res) {
     if (typeof res.cookie === 'function') {
+      /**
+       * The unit of maxAge in the specification is seconds,
+       * but in Express' cookie() method this is milliseconds
+       */
+      const fixMaxAge = typeof options?.maxAge === 'number' ? {
+        maxAge: options.maxAge * 1000
+      } : undefined;
       res.cookie(name, val, {
         ...defaultOptions,
-        ...options
+        ...options,
+        ...fixMaxAge
       });
       if (req?.cookies) {
         req.cookies[name] = val;

diff --git a/dist/server.esm.js b/dist/server.esm.js
@@ -206,9 +206,17 @@ function setCookie(name, val, options) {
   } = asyncLocalStorage.getStore() || {};
   if (res) {
     if (typeof res.cookie === 'function') {
+      /**
+       * The unit of maxAge in the specification is seconds,
+       * but in Express' cookie() method this is milliseconds
+       */
+      const fixMaxAge = typeof options?.maxAge === 'number' ? {
+        maxAge: options.maxAge * 1000
+      } : undefined;
       res.cookie(name, val, {
         ...defaultOptions,
-        ...options
+        ...options,
+        ...fixMaxAge
       });
       if (req?.cookies) {
         req.cookies[name] = val;

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "cookick",
-  "version": "1.0.1",
+  "version": "1.0.3",
   "description": "Utilities for cookie APIs",
   "author": "qiqiboy",
   "main": "dist/server.cjs.js",

diff --git a/src/server.ts b/src/server.ts
@@ -19,9 +19,21 @@ export function setCookie(name: string, val: string | number, options?: CookieOp
 
     if (res) {
         if (typeof res.cookie === 'function') {
+            /**
+             * The unit of maxAge in the specification is seconds,
+             * but in Express' cookie() method this is milliseconds
+             */
+            const fixMaxAge =
+                typeof options?.maxAge === 'number'
+                    ? {
+                          maxAge: options.maxAge * 1000
+                      }
+                    : undefined;
+
             res.cookie(name, val, {
                 ...defaultOptions,
-                ...options
+                ...options,
+                ...fixMaxAge
             });
 
             if (req?.cookies) {