Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expressions: let concat handle NULL like empty string (like in postgres) #2118

Merged
merged 1 commit into from
Jun 25, 2015

Conversation

jef-n
Copy link
Member

@jef-n jef-n commented Jun 6, 2015

To add fuel to the #1947 fire: In PostgreSQL concat ignores NULL and handles it like an empty string. This aligns our concat function with the one of our favorite database.

@jef-n jef-n force-pushed the postgres-like-concat branch from 3581521 to 3387d6f Compare June 6, 2015 09:31
@NathanW2
Copy link
Member

NathanW2 commented Jun 6, 2015

\o/

@anitagraser
Copy link
Member

Yes please +1

@m-kuhn
Copy link
Member

m-kuhn commented Jun 7, 2015

+1 to align with PG
+1 to have a string-centric method to solve the #1947 issue
-0 to do this change in a minor version change

Do we need a shorthand operator for it? I would have some suggestions :)

jef-n added a commit that referenced this pull request Jun 25, 2015
expressions: let concat handle NULL like empty string (like in postgres; fixes #1927)
@jef-n jef-n merged commit 6e3a1fa into qgis:master Jun 25, 2015
@m-kuhn
Copy link
Member

m-kuhn commented Jun 26, 2015

Thanks :)

@jef-n jef-n deleted the postgres-like-concat branch July 5, 2015 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants