From 3291b412cd28661c3b3c2e34af674d93fc10210e Mon Sep 17 00:00:00 2001 From: Ewoud Kohl van Wijngaarden Date: Fri, 5 Jan 2024 12:42:34 +0100 Subject: [PATCH] Fixes #37033 - Drop unused katello:rubocop:jenkins rake task Jenkins uses katello:rubocop and doesn't parse the results right now, so the dependency can be dropped safely. --- katello.gemspec | 1 - lib/katello/tasks/rubocop.rake | 9 --------- 2 files changed, 10 deletions(-) diff --git a/katello.gemspec b/katello.gemspec index 2be66a79b93..eb203233933 100644 --- a/katello.gemspec +++ b/katello.gemspec @@ -72,7 +72,6 @@ Gem::Specification.new do |gem| gem.add_development_dependency "mocha" gem.add_development_dependency "vcr", "< 4.0.0" gem.add_development_dependency "webmock" - gem.add_development_dependency "rubocop-checkstyle_formatter" gem.add_development_dependency "simplecov" gem.add_development_dependency "simplecov-rcov" gem.add_development_dependency "robottelo_reporter" diff --git a/lib/katello/tasks/rubocop.rake b/lib/katello/tasks/rubocop.rake index b5a301b7db3..b549cdfa2b7 100644 --- a/lib/katello/tasks/rubocop.rake +++ b/lib/katello/tasks/rubocop.rake @@ -6,13 +6,4 @@ namespace :katello do system("bundle exec rubocop -D #{Katello::Engine.root}") exit($CHILD_STATUS.exitstatus) end - - desc "Runs Rubocop style checker with xml output for Jenkins" - task 'rubocop:jenkins' do - system("bundle exec rubocop #{Katello::Engine.root} \ - --require rubocop/formatter/checkstyle_formatter \ - --format RuboCop::Formatter::CheckstyleFormatter \ - --no-color --out rubocop.xml") - exit($CHILD_STATUS.exitstatus) - end end