Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to deployAll to wait until deployment is succeeded #50

Open
christianhuening opened this issue Dec 11, 2016 · 5 comments
Open
Assignees
Milestone

Comments

@christianhuening
Copy link

Hi,

is there any way to make the deployAll task run and block until the deployed Pods are up and running? In my case we're trying to use this in a Jenkinsfile as part of an integration test suite and we're running in the problem, that the deployment task finishes too soon and thus the tests fail.

cheers
christian

@sjahreis sjahreis self-assigned this Dec 11, 2016
@sjahreis sjahreis added this to the Backlog milestone Dec 11, 2016
@sjahreis
Copy link
Contributor

sjahreis commented Dec 11, 2016

Hi christian,

Right now there is no blocking feature like that. The plugin blocks until the pods are or the deployment is created, but not until the pods are completely running.

It should be possible to implement such a feature using healthcheck adresses. We'll discuss that! I'll keep you informed!

Until that, there is no other solution than implementing such a logic in your test cases. You could use a rest client which blocks until a request is successful...

Best regards,
Simon

@christianhuening
Copy link
Author

Yeah that's what we did. The other feature would be quite nice though, I think. Thanks for your effort!

@sjahreis
Copy link
Contributor

Hi christian,

we decided to add this feature to the further roadmap (See #45). It will be added soon!

Thanks for your suggestion!

Best regards,
Simon

@sjahreis sjahreis modified the milestones: Release 1.0, Backlog Dec 15, 2016
@sjahreis
Copy link
Contributor

For Kubernetes we could use this REST endpoint:
http://kubernetes.io/kubernetes/third_party/swagger-ui/#!/api%2Fv1/readNamespacedComponentStatus

@sjahreis
Copy link
Contributor

For Marathon we could use this REST endpoint:
https://mesosphere.github.io/marathon/docs/generated/api.html#v2_apps__app_id__get

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants