Fixed Flow Control Setup on Serial Interface #483
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
When interfacing with some serial equipment that utilized DTR and DSR for flow control, I noticed I was getting communication corruption and errors. I reimplemented this project using only pyserial and didn't have any issue which is weird because pyvisa_py uses this same library on the backend. I noticed that flow control state was not being properly set, it was passing along the internal pyvisa_py constants instead of a bool which pyserial is expecting for these settings. Once I cast the values to bool my errors were fixed.
black . && isort -c . && flake8
with no errors