Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Flow Control Setup on Serial Interface #483

Merged
merged 3 commits into from
Jan 18, 2025

Conversation

natankeddem
Copy link
Contributor

Hello,
When interfacing with some serial equipment that utilized DTR and DSR for flow control, I noticed I was getting communication corruption and errors. I reimplemented this project using only pyserial and didn't have any issue which is weird because pyvisa_py uses this same library on the backend. I noticed that flow control state was not being properly set, it was passing along the internal pyvisa_py constants instead of a bool which pyserial is expecting for these settings. Once I cast the values to bool my errors were fixed.

  • Closes # (insert issue number if relevant)
  • Executed black . && isort -c . && flake8 with no errors
  • The change is fully covered by automated unit tests
  • Documented in docs/ as appropriate
  • Added an entry to the CHANGES file

@MatthieuDartiailh
Copy link
Member

Thanks for your PR. Could you add an entry to the release notes ?

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 24.41%. Comparing base (2937877) to head (481875f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pyvisa_py/serial.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #483   +/-   ##
=======================================
  Coverage   24.41%   24.41%           
=======================================
  Files          23       23           
  Lines        3514     3514           
  Branches      401      401           
=======================================
  Hits          858      858           
  Misses       2651     2651           
  Partials        5        5           
Flag Coverage Δ
unittests 24.41% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CHANGES Outdated Show resolved Hide resolved
@MatthieuDartiailh MatthieuDartiailh merged commit 7982940 into pyvisa:main Jan 18, 2025
17 of 18 checks passed
@MatthieuDartiailh
Copy link
Member

Thanks again for your contribution.

@natankeddem
Copy link
Contributor Author

Thanks again for your contribution.

Thank you for the quick merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants