Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement open timeout for hislip #430

Merged
merged 17 commits into from
Dec 29, 2024
Merged

Conversation

MatthieuDartiailh
Copy link
Member

No description provided.

Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 26.25000% with 59 lines in your changes missing coverage. Please review.

Project coverage is 24.41%. Comparing base (8b47818) to head (5842b03).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pyvisa_py/tcpip.py 12.50% 14 Missing ⚠️
pyvisa_py/protocols/rpc.py 7.14% 13 Missing ⚠️
pyvisa_py/gpib.py 20.00% 8 Missing ⚠️
pyvisa_py/highlevel.py 38.46% 8 Missing ⚠️
pyvisa_py/protocols/hislip.py 0.00% 6 Missing ⚠️
pyvisa_py/sessions.py 40.00% 6 Missing ⚠️
pyvisa_py/serial.py 50.00% 2 Missing ⚠️
pyvisa_py/usb.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #430      +/-   ##
==========================================
- Coverage   24.42%   24.41%   -0.02%     
==========================================
  Files          23       23              
  Lines        3492     3514      +22     
  Branches      400      401       +1     
==========================================
+ Hits          853      858       +5     
- Misses       2634     2651      +17     
  Partials        5        5              
Flag Coverage Δ
unittests 24.41% <26.25%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MatthieuDartiailh MatthieuDartiailh force-pushed the hislip-connect-timeout branch 2 times, most recently from db8f22b to 7959ea5 Compare September 17, 2024 17:25
@MatthieuDartiailh MatthieuDartiailh merged commit b4693f6 into main Dec 29, 2024
18 of 19 checks passed
@MatthieuDartiailh MatthieuDartiailh deleted the hislip-connect-timeout branch December 29, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant