Code

Refactor loss plumbing#204

Code

Open

dmarx wants to merge 19 commits intotestpytti-tools/pytti-core:testfrom refactor_loss_plumbingpytti-tools/pytti-core:refactor_loss_plumbingCopy head branch name to clipboard

+275-437

Commits

Commits on Jun 23, 2022

• replaced build_loss() cls.TargetImage invocation with conventional init

  dmarx

  committed
  1b6d8b6

  Copy full SHA for 1b6d8b6

• isolated parse_subprompt(), eliminated another TargetImage invocation

  dmarx

  committed
  06722e0

  Copy full SHA for 06722e0

• added refactoring test suite

  dmarx

  committed
  6e2b23a

  Copy full SHA for 6e2b23a

• added test

  dmarx

  committed
  561425a

  Copy full SHA for 561425a

• added test, eliminated TargetImage in pixel.py

  dmarx

  committed
  2cb7568

  Copy full SHA for 2cb7568

• why did that test pass? hmm...

  dmarx

  committed
  087f226

  Copy full SHA for 087f226

• eliminated TargetImage for video flow

  dmarx

  committed
  bfca0ee

  Copy full SHA for bfca0ee

• cleaned up deprecated code

  dmarx

  committed
  7b36c30

  Copy full SHA for 7b36c30

• refactor seems sound but emitting a cuda error now

  dmarx

  committed
  9ea18d6

  Copy full SHA for 9ea18d6

• tinkering with device selection, cuda error still there even after restarting computer and reinstalling torch

  dmarx

  committed
  00046d3

  Copy full SHA for 00046d3

• fixed attribute error

  dmarx

  committed
  0f0b62a

  Copy full SHA for 0f0b62a

• specified device in make_comp call of build_loss

  dmarx

  committed
  9ad0bb7

  Copy full SHA for 9ad0bb7

• CUDA assertion error was caused by 3D mode with null transforms. added z translation to test, all passing. TO DO: document this edge case with a failing test

  dmarx

  committed
  a7239a8

  Copy full SHA for a7239a8

• add xfail test for null 3d transform cuda error

  dmarx

  committed
  0adc838

  Copy full SHA for 0adc838

• suppressed old LossOrchestration classes

  dmarx

  committed
  4201442

  Copy full SHA for 4201442

• cleaned up a deprecated code

  dmarx

  committed
  09fc46b

  Copy full SHA for 09fc46b

• removed now unused TargetImage method defs

  dmarx

  committed
  f73e604

  Copy full SHA for f73e604

• added some notes and removed more dead code

  dmarx

  committed
  cdda5c0

  Copy full SHA for cdda5c0

• reorganized configure_optical_flows to not initialize for null flow weight

  dmarx

  committed
  d0bf637

  Copy full SHA for d0bf637