Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed transfer reported as success when file was deleted before transfer completed #154

Open
pnuu opened this issue Jan 25, 2023 · 0 comments
Labels

Comments

@pnuu
Copy link
Member

pnuu commented Jan 25, 2023

Describe the bug
If there's a delay in processing the request made by the Client (for example due to scp timeouts) and the file-to-be-transferred is deleted by Trollmoves Server before this, the transfer is still reported as success.

To Reproduce
Delete a file that is being transferred, I guess.

Expected behavior
No message is sent, if the original file isn't available and the transfer fails.

Actual results

[2023-01-25 12:56:25,109 DEBUG    trollmoves.server] We have a match: /data/eumetcast/hvs-1/E1H-TPG-2/IMG_DK01B01_202301251249_010.bz2
...
[2023-01-25 12:56:25,352 DEBUG    trollmoves.server] Bunzipped /data/eumetcast/hvs-1/E1H-TPG-2/IMG_DK01B01_202301251249_010.bz2 to /tmp/himawari/IMG_DK01B01_202301251249_010
...
[2023-01-25 12:56:25,608 DEBUG    trollmoves.server] Scheduling /tmp/himawari/IMG_DK01B01_202301251249_010 for removal in 30s
...
[2023-01-25 12:56:54,654 DEBUG    trollmoves.server] Received a request
...
[2023-01-25 12:56:55,610 DEBUG    trollmoves.server] Removed /tmp/himawari/IMG_DK01B01_202301251249_010.
...
[2023-01-25 12:57:01,962 ERROR    trollmoves.movers] No such file or directory. File not transfered: /tmp/himawari/IMG_DK01B01_202301251249_010. Original error message: [Errno 2] No such file or directory: '/tmp/himawari/IMG_DK01B01_202301251249_010'
[2023-01-25 12:57:01,962 DEBUG    paramiko.transport] [chan 49] EOF sent (49)
[2023-01-25 12:57:01,963 INFO     trollmoves.movers] Successfully copied /tmp/himawari/IMG_DK01B01_202301251249_010 to scp://host/path/

... followed by a Posttroll file message about the successful transfer. This message is then propagated until the missing file is causing a crash in Trollflow2/Satpy.

Screenshots

Environment Info:

  • OS: Linux
  • Trollmoves Version: 0.10.0

Additional context

@pnuu pnuu added the bug label Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant