Update README.md to recommend torch_xla cxx11 builds by default. #8624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Torch builds are compiled with cxx11 by default. Following the change, I think that we should also change our default builds to compiled with cxx11 abi. For now, I am just updating the README to recommend cxx11 torch_xla builds and removing the sections about pre-cxx11 builds to avoid confusion. Follow up PR will change the default builds to be compiled with cxx11 abi
tengyifei
approved these changes
Jan 24, 2025
zpcore
pushed a commit
that referenced
this pull request
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Torch builds are compiled with cxx11 by default. Following the change, I think that we should also change our default builds to compiled with cxx11 abi.
For now, I am just updating the README to recommend cxx11 torch_xla builds and removing the sections about pre-cxx11 builds to avoid confusion.
Follow up PR will change the default builds to be compiled with cxx11 abi