Add pageable/pinned tensor to cuda reliability note in pinmem tutorial #3261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3261
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a019acb with merge base 13d365c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
vmoens
force-pushed
the
add-pin-mem-caveat
branch
2 times, most recently
from
efb8e51 to
a707b7f
Compare
svekars
added
the
rl
svekars
reviewed
Jan 28, 2025
| # However, in other cases we cannot make the same asusmption: when a tensor is placed in pinned memory, mutating the | ||
| # original copy after calling the host-to-device transfer may corrupt the data received on GPU. | ||
| # Similarly, when a transfer is achieved in the opposite direction, from GPU to CPU, or from any device that is not CPU | ||
| # or GPU to any device that is not a CUDA-handled GPU (e.g., MPS), there is no guarantee that the data read on GPU is |
There was a problem hiding this comment.
Suggested change
| # or GPU to any device that is not a CUDA-handled GPU (e.g., MPS), there is no guarantee that the data read on GPU is | |
| # or GPU to any device that is not a CUDA-handled GPU (such as, MPS), there is no guarantee that the data read on GPU is |
3 tasks
vmoens
force-pushed
the
add-pin-mem-caveat
branch
from
4812b2a to
b612d61
Compare
vmoens
force-pushed
the
add-pin-mem-caveat
branch
from
b612d61 to
a019acb
Compare
|
@svekars I corrected the spelling - should be good for final review |
svekars
approved these changes
Feb 19, 2025
svekars
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some more info on when it is unsafe to use
non_blocking(namely with pinned tensors)cc @nairbv