Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spellcheck to run only on changed files #3233

Merged
merged 28 commits into from
Jan 29, 2025
Merged

Conversation

svekars
Copy link
Contributor

@svekars svekars commented Jan 16, 2025

.rst, .md, and .py file changes are included for testing purposes only and will not be merged.

Copy link

pytorch-bot bot commented Jan 16, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3233

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 44fd093 with merge base 903f7af (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@svekars svekars marked this pull request as draft January 16, 2025 21:18
@svekars svekars marked this pull request as ready for review January 23, 2025 21:09
@svekars svekars requested review from malfet and clee2000 January 23, 2025 21:09
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, though unless it's slowest job, it probably would be better to run spell checking on all files, as those kinds of changes increase the chances that changed file will be skipped or complex PR will fail the lint due to bugs in the script

@malfet malfet merged commit a75c791 into main Jan 29, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants