-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ONNX] Update API to torch.onnx.export(..., dynamo=True) #3223
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3223
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@svekars PTAL |
beginner_source/onnx/export_control_flow_model_to_onnx_tutorial.py
Outdated
Show resolved
Hide resolved
beginner_source/onnx/export_control_flow_model_to_onnx_tutorial.py
Outdated
Show resolved
Hide resolved
beginner_source/onnx/export_control_flow_model_to_onnx_tutorial.py
Outdated
Show resolved
Hide resolved
beginner_source/onnx/export_control_flow_model_to_onnx_tutorial.py
Outdated
Show resolved
Hide resolved
beginner_source/onnx/export_control_flow_model_to_onnx_tutorial.py
Outdated
Show resolved
Hide resolved
beginner_source/onnx/export_control_flow_model_to_onnx_tutorial.py
Outdated
Show resolved
Hide resolved
beginner_source/onnx/export_control_flow_model_to_onnx_tutorial.py
Outdated
Show resolved
Hide resolved
beginner_source/onnx/export_control_flow_model_to_onnx_tutorial.py
Outdated
Show resolved
Hide resolved
beginner_source/onnx/export_control_flow_model_to_onnx_tutorial.py
Outdated
Show resolved
Hide resolved
beginner_source/onnx/export_control_flow_model_to_onnx_tutorial.py
Outdated
Show resolved
Hide resolved
beginner_source/onnx/export_control_flow_model_to_onnx_tutorial.py
Outdated
Show resolved
Hide resolved
I don’t see print outputs here either https://pytorch.org/tutorials/beginner/onnx/intro_onnx.html. Do we need to do something to enable it? (If there is an option) |
They have prints here https://pytorch.org/tutorials/intermediate/torchrec_intro_tutorial.html |
Yeah, I don't know. I tried a local build, and registry has the print out while control flow does not. |
a983c2a
to
e104e01
Compare
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of editorial suggestions.
# * Overriding the implementation of an existing PyTorch operator | ||
# * Using custom ONNX operators | ||
# * Supporting a custom PyTorch operator | ||
# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a Prerequisites section, it could look like:
# | |
# | |
# Prerequisites | |
# ~~~~~~~~~~~~~~~ | |
# | |
# Before starting this tutorial, make sure you have completed the following prerequisites: | |
# | |
# * Completed the `ONNX Script tutorial <https://github.com/microsoft/onnxscript/blob/main/docs/tutorial/index.md>`_ | |
# * You have the target PyTorch operator | |
# * You are familiar with the implementation of the operator using `ONNX Script <https://github.com/microsoft/onnxscript>`__ | |
# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
# * Using custom ONNX operators | ||
# * Supporting a custom PyTorch operator | ||
# | ||
# Overriding the implementation of an existing PyTorch operator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add a What you will learn section. Example:
In this tutorial, you will learn:
- How to override or add support for PyTorch operators in ONNX.
- How to integrate custom ONNX operators for specialized runtimes.
- How to implement and translate custom PyTorch operators to ONNX.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove dot for consistency.
@svekars Should we skip link checker on this PR, since it's newly added page? Or is there anything I missed to enable the link? |
@svekars bump |
skip-linkcheck because the failing link will become live after PR is merged. |
@svekars Sorry, could you approve the workflows again? I missed the misspelled words. Could you also point me to the local repro of misspelled word checks? Thank you! |
|
Fixes #3200
Description
Checklist
TODO: The registry doc also needs an update.
cc @justinchuby